🐛 Mitigates "Projects not being listed on osparc-staging.io" #7836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7836 +/- ##
==========================================
- Coverage 86.70% 82.54% -4.17%
==========================================
Files 1851 704 -1147
Lines 71968 33587 -38381
Branches 1218 176 -1042
==========================================
- Hits 62403 27724 -34679
+ Misses 9223 5805 -3418
+ Partials 342 58 -284
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
pcrespov
force-pushed
the
is7814/fix-service-listing-in-project-read-operations
branch
from
b8581d6 to
02172f7
Compare
pcrespov
changed the title
pcrespov
requested review from
GitHK,
matusdrobuliak66 and
sanderegg
as code owners
matusdrobuliak66
approved these changes
Jun 5, 2025
GitHK
approved these changes
Jun 6, 2025
services/web/server/src/simcore_service_webserver/catalog/_catalog_rest_client_service.py
Show resolved
Hide resolved
pcrespov
force-pushed
the
is7814/fix-service-listing-in-project-read-operations
branch
2 times, most recently
from
bf20812 to
0012e8a
Compare
…ervices_with_versions for improved clarity and caching
pcrespov
force-pushed
the
is7814/fix-service-listing-in-project-read-operations
branch
from
0012e8a to
f9904d3
Compare
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
|
pcrespov
deleted the
is7814/fix-service-listing-in-project-read-operations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Mitigates performance bottleneck when retrieving project(s)
Calls to
get_services_for_user_in_productwere causing significant delays, occasionally leading to timeouts when calling the following endpoints:GET /projects/{project_id}GET /projectsThe root cause was a legacy call to a deprecated
catalog RESTendpoint that lists all services for a given user and product. This was originally used to determine whether the services associated with a project were accessible. However, more efficient alternatives are now available (e.g.catalog_service.batch_get_my_services), though the code was never updated.As an interim solution, this PR introduces:
This change significantly improves the performance of the affected endpoints and mitigates the timeout issues reported in #7814.
Related issue/s
get_services_for_user_in_product#7838How to test
Dev-ops